build(evaluators): normalize package-local Makefile targets#192
Closed
lan17 wants to merge 1 commit intofeature/contrib-budget-check-fixesfrom
Closed
build(evaluators): normalize package-local Makefile targets#192lan17 wants to merge 1 commit intofeature/contrib-budget-check-fixesfrom
lan17 wants to merge 1 commit intofeature/contrib-budget-check-fixesfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
lan17
changed the title
lan17
changed the title
lan17
force-pushed
the
feature/contrib-makefile-contract
branch
from
57503af to
8d2410d
Compare
Contributor
Author
|
Superseded by #193, which rolls up this reviewed stack into one PR while preserving the logical commit boundaries for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
checktarget to the Galileo and Cisco contrib package Makefilespytest,ruff, andmypywithuv run --package <contrib-package>so the local contrib project stays selected outside the root workspaceWhy
The contrib packages live outside the root
uvworkspace, so package-localuv runbehavior can drift from the root-drivenmake -C <package>flow. Galileo was failing before the tool even reached the package code because the command resolution did not reliably run in the local project context.Impact
Root automation can rely on both contrib packages exposing
test,lint,lint-fix,typecheck,check, andbuildwithout package-specific command drift blocking the contrib contract cleanup.Validation
make -C evaluators/contrib/galileo lint-fixmake -C evaluators/contrib/galileo checkmake -C evaluators/contrib/galileo buildmake -C evaluators/contrib/cisco lint-fixmake -C evaluators/contrib/cisco checkmake -C evaluators/contrib/cisco buildDesign Context